epp: add basic support - #10
Open
lollipopman wants to merge 1 commit into
Open
lollipopman wants to merge 1 commit into
lollipopman wants to merge 1 commit into
Conversation
Add basic epp support by allowing lamda style parameter lists at the beginning of a source file. The downside of this change is that it would allow the same syntax in a regular Puppet source file, where the syntax would be illegal. An alternative approach would be to generate two grammar's from a common subset. This approach is taken by https://github.com/tree-sitter/tree-sitter-typescript. That approach adds a fair bit of complexity, but I'm happy to take it on, if you don't care for this approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic epp support by allowing lamda style parameter lists at the beginning of a source file. The downside of this change is that it would allow the same syntax in a regular Puppet source file, where the syntax would be illegal.
An alternative approach would be to generate two grammar's from a common subset. This approach is taken by
https://github.com/tree-sitter/tree-sitter-typescript.
That approach adds a fair bit of complexity, but I'm happy to take it on, if you don't care for this approach.