Send env argument to subprocess.Popen#304
Merged
slhck merged 2 commits intoslhck:masterfrom Feb 3, 2026
Merged
Conversation
Consumers can pass an environment dict to subprocess.Popen uses by using the context manager ffmpeg_env. Thread safety is ensured by contextvars.ContextVar.
randompersona1
changed the title
env argument to subprocess.Popen
Owner
|
Thanks, this is released now! |
Contributor
Author
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #303
At first, I assumed I could just add an optional env argument everywhere, but that turned out to be incredibly convoluted, as the call stack wasn't really designed for that.
Instead, a small context manager modifies the environment inside its scope. Thread safety is guaranteed by a ContextVar.
Test case ensures the simple invocation works. Wasn't exactly sure how to integrate it into the existing test structure, since it's more of a "meta" change, not strictly related to normalizing.
Let me know if and how to update docs, changelog, etc.