Skip to content

Commit 4639eee

Browse files
WilliamBergaminClaudemwbrooks
authored
fix(models): skip unknown view state values instead of crashing (#2043)
Co-authored-by: Claude <svc-devxp-claude@slack-corp.com> Co-authored-by: Michael Brooks <mbrooks@slack-corp.com>
1 parent f4b0575 commit 4639eee

2 files changed

Lines changed: 17 additions & 3 deletions

File tree

‎slack_sdk/models/views/__init__.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def __init__(
148148
if actions is None:
149149
continue
150150
elif isinstance(actions, dict):
151-
new_actions: Dict[str, Union[ViewStateValue, dict]] = copy.copy(actions)
151+
new_actions: Dict[str, ViewStateValue] = {}
152152
for action_id, v in actions.items():
153153
if isinstance(v, dict):
154154
d = copy.copy(v)
@@ -159,9 +159,9 @@ def __init__(
159159
self._show_warning_about_unknown(v)
160160
continue
161161
new_actions[action_id] = value_object
162-
value_objects[block_id] = new_actions # type: ignore[assignment]
162+
value_objects[block_id] = new_actions
163163
else:
164-
self._show_warning_about_unknown(v)
164+
self._show_warning_about_unknown(actions)
165165
self.values = value_objects
166166

167167
def to_dict(self, *args) -> Dict[str, Dict[str, Dict[str, dict]]]:

‎tests/slack_sdk/models/test_views.py‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,20 @@ def test_simple_state_values(self):
144144
self.assertDictEqual(expected, ViewState(**expected).to_dict())
145145
self.assertDictEqual(expected, state.to_dict())
146146

147+
def test_state_values_skip_unknown_action_value(self):
148+
with self.assertLogs("slack_sdk.models.views", level="WARNING") as logs:
149+
state = ViewState(values={"b1": {"a1": 123, "a2": {"type": "plain_text_input", "value": "Title"}}})
150+
self.assertIn("builtins.int", logs.output[0])
151+
self.assertDictEqual({"values": {"b1": {"a2": {"type": "plain_text_input", "value": "Title"}}}}, state.to_dict())
152+
153+
def test_state_values_skip_unknown_block_actions(self):
154+
with self.assertLogs("slack_sdk.models.views", level="WARNING") as logs:
155+
state = ViewState(values={"b2": {"a2": {"type": "plain_text_input", "value": "Title"}}, "b1": "oops"})
156+
self.assertIn("builtins.str", logs.output[0])
157+
self.assertDictEqual({"values": {"b2": {"a2": {"type": "plain_text_input", "value": "Title"}}}}, state.to_dict())
158+
with self.assertLogs("slack_sdk.models.views", level="WARNING"):
159+
self.assertDictEqual({"values": {}}, ViewState(values={"b1": "oops"}).to_dict())
160+
147161
def test_all_state_values(self):
148162
# Testing with
149163
# {"type":"modal","title":{"type":"plain_text","text":"My App","emoji":true},"submit":{"type":"plain_text","text":"Submit","emoji":true},"close":{"type":"plain_text","text":"Cancel","emoji":true},"blocks":[{"type":"input","element":{"type":"plain_text_input"},"label":{"type":"plain_text","text":"Label","emoji":true}},{"type":"input","element":{"type":"plain_text_input","multiline":true},"label":{"type":"plain_text","text":"Label","emoji":true}},{"type":"input","element":{"type":"datepicker","initial_date":"1990-04-28","placeholder":{"type":"plain_text","text":"Select a date","emoji":true}},"label":{"type":"plain_text","text":"Label","emoji":true}},{"type":"input","element":{"type":"users_select","placeholder":{"type":"plain_text","text":"Select a user","emoji":true}},"label":{"type":"plain_text","text":"Label","emoji":true}},{"type":"input","element":{"type":"multi_static_select","placeholder":{"type":"plain_text","text":"Select options","emoji":true},"options":[{"text":{"type":"plain_text","text":"*this is plain_text text*","emoji":true},"value":"value-0"},{"text":{"type":"plain_text","text":"*this is plain_text text*","emoji":true},"value":"value-1"},{"text":{"type":"plain_text","text":"*this is plain_text text*","emoji":true},"value":"value-2"}]},"label":{"type":"plain_text","text":"Label","emoji":true}},{"type":"input","element":{"type":"checkboxes","options":[{"text":{"type":"plain_text","text":"*this is plain_text text*","emoji":true},"value":"value-0"},{"text":{"type":"plain_text","text":"*this is plain_text text*","emoji":true},"value":"value-1"},{"text":{"type":"plain_text","text":"*this is plain_text text*","emoji":true},"value":"value-2"}]},"label":{"type":"plain_text","text":"Label","emoji":true}},{"type":"input","element":{"type":"radio_buttons","initial_option":{"text":{"type":"plain_text","text":"Option 1"},"value":"option 1","description":{"type":"plain_text","text":"Description for option 1"}},"options":[{"text":{"type":"plain_text","text":"Option 1"},"value":"option 1","description":{"type":"plain_text","text":"Description for option 1"}},{"text":{"type":"plain_text","text":"Option 2"},"value":"option 2","description":{"type":"plain_text","text":"Description for option 2"}},{"text":{"type":"plain_text","text":"Option 3"},"value":"option 3","description":{"type":"plain_text","text":"Description for option 3"}}]},"label":{"type":"plain_text","text":"Label","emoji":true}}]}

0 commit comments

Comments
 (0)