Skip to content

Commit f4b0575

Browse files
WilliamBergaminClaude
andauthored
fix(models): accept unknown view state value keys (#2042)
Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
1 parent a078670 commit f4b0575

2 files changed

Lines changed: 18 additions & 0 deletions

File tree

‎slack_sdk/models/views/__init__.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ def __init__(
208208
selected_channels: Optional[Sequence[str]] = None,
209209
selected_users: Optional[Sequence[str]] = None,
210210
selected_options: Optional[Sequence[Union[dict, Option]]] = None,
211+
**kwargs,
211212
):
212213
self.type = type
213214
self.value = value
@@ -230,3 +231,4 @@ def __init__(
230231
self.selected_options.append(Option(**option))
231232
else:
232233
self.selected_options = selected_options # type: ignore[assignment]
234+
self.additional_attributes = kwargs

‎tests/slack_sdk/models/test_views.py‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,22 @@ def test_view_state_value_with_selected_options(self):
345345

346346
self.assertDictEqual(expected, ViewStateValue(**input).to_dict())
347347

348+
def test_view_state_value_with_unknown_keys(self):
349+
input = {"type": "datetimepicker", "selected_date_time": 1700000000}
350+
351+
view_state_value = ViewStateValue(**input)
352+
self.assertDictEqual({"selected_date_time": 1700000000}, view_state_value.additional_attributes)
353+
self.assertDictEqual({"type": "datetimepicker"}, view_state_value.to_dict())
354+
355+
def test_view_with_unknown_state_value_keys(self):
356+
view = View(
357+
type="modal",
358+
title="Schedule",
359+
blocks=[],
360+
state={"values": {"b1": {"a1": {"type": "datetimepicker", "selected_date_time": 1700000000}}}},
361+
)
362+
self.assertIsInstance(view.state.values["b1"]["a1"], ViewStateValue)
363+
348364
def test_load_modal_view_001(self):
349365
with open("tests/slack_sdk_fixture/view_modal_001.json") as file:
350366
self.verify_loaded_view_object(file)

0 commit comments

Comments
 (0)