Skip to content

feat(gitops): open resource drawer when clicking an app's own root node - #1610

Merged
hisco merged 1 commit into
skyhook-io:mainfrom
jfillman:feature/gitops-topology-root-click-drawer
Sep 4, 2026
Merged

hisco merged 1 commit into
skyhook-io:mainfrom
jfillman:feature/gitops-topology-root-click-drawer

Conversation

@jfillman

@jfillman jfillman commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The GitOps detail page's Topology tab treats its own root node as a no-op on click — correctly, to avoid navigating to a stacked copy of the same page. But that left the root node without any click affordance at all, while every other resource in the tree opens the standard resource drawer.

A click on the root node now opens the standard resource drawer for that same resource, matching the rest of Radar's click behavior, while still skipping the self-referential navigation.

Test plan

  • Manually verified on a live Application — clicking the root card opens its own drawer instead of doing nothing
  • Clicking any child node still navigates as before

Note

Low Risk
Localized GitOps topology UX change; reuses existing resource-drawer flow and does not alter auth, APIs, or child-node navigation.

Overview
Clicking the topology root node on a GitOps detail page no longer does nothing. When the click refers to the same resource as the page (openResourceFromTree self-match), it now calls onOpenResource so Radar opens the standard resource drawer (metadata/YAML), while still avoiding nested navigation to another copy of the same GitOps detail view.

In GitOpsTreeGraph, root nodes get a quieter click affordance than GitOps portal children: cursor-pointer and a hover-only tertiary ring, without the skyhook portal ring at rest, so the subject node reads as clickable but not as “dive into another GitOps page.”

Reviewed by Cursor Bugbot for commit 6d5a8e3. Bugbot is set up for automated code reviews on this repo. Configure here.

The GitOps detail page's Topology tab treats its root node as a no-op on
click (correctly, to avoid navigating to a stacked copy of the same page),
but that left the root node without any click affordance at all — every
other resource in the tree opens the standard resource drawer, the root
node opened nothing.

Now a click on the root node opens the standard resource drawer for that
same resource, matching the rest of Radar's click behavior, while still
skipping the self-referential navigation.
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Open resource drawer from GitOps topology root

✨ Enhancement 🕐 10-20 Minutes

Grey Divider

AI Description

• Opens the standard resource drawer when the GitOps topology root is clicked.
• Preserves detail-page navigation for child GitOps resources.
• Adds a subtle hover affordance to communicate root-node interactivity.
Diagram

graph TD
  U["Topology click"] --> G["Tree graph"] --> H["Resource handler"] --> S{"Self reference?"} -->|Root| D["Resource drawer"]
  S -->|Child| N["GitOps detail"]
Loading
High-Level Assessment

The PR's approach is optimal: it reuses the existing resource-opening callback and retains the self-navigation guard. Navigating to the same detail route or adding a separate root-only action would create redundant history or inconsistent topology behavior.

Files changed (2) +17 / -1

Enhancement (2) +17 / -1
GitOpsTreeGraph.tsxAdd root-node click affordance +7/-0

Add root-node click affordance

• Marks non-highlighted root cards as interactive and adds a subtle hover ring. The quieter styling distinguishes drawer access from portal nodes that navigate deeper into GitOps views.

packages/k8s-ui/src/components/gitops/tree/GitOpsTreeGraph.tsx

GitOpsView.tsxOpen the resource drawer for self-referencing root clicks +10/-1

Open the resource drawer for self-referencing root clicks

• Changes the current-resource branch from a no-op to an 'onOpenResource' call. Child GitOps resources still navigate to their detail pages, preventing stacked copies of the current page.

web/src/components/gitops/GitOpsView.tsx

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@hisco
hisco force-pushed the feature/gitops-topology-root-click-drawer branch from 6d5a8e3 to d6735fd Compare September 3, 2026 20:45
@hisco
hisco merged commit 4707bdd into skyhook-io:main Sep 4, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants