Conversation
telome
commented
Jun 23, 2026
Comment on lines
+127
to
+130
| require(ccip.hasRole(MESSAGE_LIB_ROLE, sendLib), "LZAvaxMigrationInit/ccip-sendlib-missing-role"); | ||
| require(ccip.hasRole(ALLOWLIST, govSender), "LZAvaxMigrationInit/ccip-gov-sender-not-allowlisted"); | ||
| require(ccip.allowlistSize() == 1, "LZAvaxMigrationInit/ccip-allowlist-not-singleton"); | ||
| require(ccip.hasRole(DEFAULT_ADMIN_ROLE, pProxy), "LZAvaxMigrationInit/ccip-admin-not-handed-off"); |
Author
There was a problem hiding this comment.
There is some chance these checks will be executed unnecessarily in case the avalanche migration comes after the integration of some new L2, for which these sanity checks would normally already have been run (though in theory the new L2 might not have CCIP support). We could wrap them under some boolean param check, or under a check that e.g. chainlog.getAddress("USDS_OFT") == OLD_L1_USDS_OFT, but I'm currently choosing to just re-execute the checks for now, for simplicity. The same goes for some of the global sanity checks done in LZInit.activateOft.
oldchili
reviewed
Jun 26, 2026
oldchili
reviewed
Jun 29, 2026
Contributor
|
So far all looks good to me. |
oldchili
reviewed
Jun 29, 2026
Co-authored-by: sunbreak1211 <129470872+sunbreak1211@users.noreply.github.com>
sunbreak1211
reviewed
Jul 1, 2026
sunbreak1211
reviewed
Jul 1, 2026
sunbreak1211
reviewed
Jul 1, 2026
sunbreak1211
reviewed
Jul 1, 2026
Co-authored-by: sunbreak1211 <129470872+sunbreak1211@users.noreply.github.com>
oldchili
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.