feat: add updateFarmVest init function#38
Merged
Conversation
amusingaxl
force-pushed
the
feat/update-farm-vest
branch
from
October 7, 2025 21:44
a083f3e to
e5e00d6
Compare
Signed-off-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com>
amusingaxl
marked this pull request as ready for review
October 31, 2025 17:00
0xLaz3r
requested changes
Nov 11, 2025
0xLaz3r
previously approved these changes
Nov 16, 2025
oddaf
reviewed
Dec 3, 2025
- Validate vestTot > 0 to prevent zero total vesting - Validate vestTau > 0 to prevent division by zero - Check that distribution vestId is already set (not zero) - Verify vest gem matches distribution gem - Fix error message prefix from initFarm to updateFarmVest - Add comprehensive test coverage for invalid parameters
- Check if vest cap needs adjustment when required rate exceeds current cap - Set cap to rate with 10% buffer when adjustment is needed - Refactor allowance calculation into scoped block for clarity - Add comprehensive test coverage for cap adjustment scenarios - Add tests for allowance calculation and vest creation parameters
Replace generic error messages with descriptive ones that clearly explain what operation failed and what the expected behavior should be.
oddaf
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.