Clean up base plugin class, add tests and CI#1
Merged
Conversation
The base class had a log() method that was unreachable because the constructor assigned this.log to the logger instance, shadowing the prototype method. Plugin authors who tried the documented wrapper got the raw logger instead. Remove the wrapper so what's documented matches what's actually used. While here, surface bad usage earlier: validate that the config object has the required fields up front with a clear error, instead of letting a confusing Cannot read properties of undefined escape later. Add a real README an engines field, and a minimal node:test suite plus a GitHub Actions workflow so regressions in the base class get caught before they reach plugin authors. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base class had a log() method that was unreachable because the
constructor assigned this.log to the logger instance, shadowing the
prototype method. Plugin authors who tried the documented wrapper got
the raw logger instead. Remove the wrapper so what's documented matches
what's actually used.
While here, surface bad usage earlier: validate that the config object
has the required fields up front with a clear error, instead of letting
a confusing Cannot read properties of undefined escape later.
Add a real README an engines field,
and a minimal node:test suite plus a GitHub Actions workflow so
regressions in the base class get caught before they reach plugin
authors.
Co-authored-by: Claude noreply@anthropic.com