Stop shipping build-only deps and drop deprecated apt-key#8
Open
soulgalore wants to merge 1 commit into
Open
Conversation
The buildDeps shell variable was set in one RUN and referenced in another, so it was empty by the time apt-get purge --auto-remove ran — meaning gnupg, wget, curl, software-properties-common and friends were never actually removed and have been riding along in every published image. Moving the list to a Dockerfile-level ARG puts it back in scope for the purge. ca-certificates is dropped from that list so the runtime install on the line below keeps it around for TLS. The Google Chrome signing key was still being added with apt-key, which is deprecated and removed in newer Ubuntu releases. Switching to the keyrings + signed-by= pattern (the same one already used for Mozilla) keeps the amd64 build working as base images move forward. Co-authored-by: Claude [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buildDeps shell variable was set in one RUN and referenced in
another, so it was empty by the time apt-get purge --auto-remove
ran — meaning gnupg, wget, curl, software-properties-common and
friends were never actually removed and have been riding along in
every published image. Moving the list to a Dockerfile-level ARG
puts it back in scope for the purge. ca-certificates is dropped from
that list so the runtime install on the line below keeps it around
for TLS.
The Google Chrome signing key was still being added with apt-key,
which is deprecated and removed in newer Ubuntu releases. Switching
to the keyrings + signed-by= pattern (the same one already used for
Mozilla) keeps the amd64 build working as base images move forward.
Co-authored-by: Claude [email protected]