Lift CDP renderBlockingStatus onto entries as _renderBlocking#155
Merged
Conversation
Chrome's CDP has carried the per-request render-blocking classification on
Network.requestWillBeSent.params.renderBlockingStatus since Chrome 108, but chrome-har silently
dropped it on the floor. Downstream HAR consumers (waterfall-tools' WPT-style renderer in
particular) match _renderBlocking === 'blocking' to draw the orange ⊗ marker on each request that
delays first paint, and without this field the marker never appears regardless of how blocking the
CSS or script actually was. CDP emits the value in PascalCase ('Blocking', 'NonBlocking',
'InBodyParserBlocking', 'PotentiallyBlocking'); we lowercase before storing so the renderer's
case-sensitive equality check works without each consumer having to re-normalise. Older Chrome
builds that don't emit the field leave _renderBlocking unset, distinguishing "not blocking" from
"browser couldn't tell us" — the same tri-state convention used elsewhere in the project.
Co-authored-by: Claude Opus 4.7 (1M context) [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome's CDP has carried the per-request render-blocking classification on Network.requestWillBeSent.params.renderBlockingStatus since Chrome 108, but chrome-har silently dropped it on the floor. Downstream HAR consumers (waterfall-tools' WPT-style renderer in particular) match _renderBlocking === 'blocking' to draw the orange ⊗ marker on each request that delays first paint, and without this field the marker never appears regardless of how blocking the CSS or script actually was. CDP emits the value in PascalCase ('Blocking', 'NonBlocking', 'InBodyParserBlocking', 'PotentiallyBlocking'); we lowercase before storing so the renderer's case-sensitive equality check works without each consumer having to re-normalise. Older Chrome builds that don't emit the field leave _renderBlocking unset, distinguishing "not blocking" from "browser couldn't tell us" — the same tri-state convention used elsewhere in the project.
Co-authored-by: Claude Opus 4.7 (1M context) [email protected]