Fix recording-file parameter ignores for pcap recording method#2087
Closed
fergusean wants to merge 1 commit intosipwise:masterfrom
Closed
Fix recording-file parameter ignores for pcap recording method#2087fergusean wants to merge 1 commit intosipwise:masterfrom
fergusean wants to merge 1 commit intosipwise:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using the
pcaprecording method, therecording-fileparameter passed in a "start recording" NG command was silently ignored — the file was always created at an auto-generated path (<spooldir>/pcaps/<callid>-<random>.pcap) instead of the caller-specified one.Root Cause
The
recording-filevalue is correctly parsed and stored in the call struct, but the pcap initialization code never consulted it when opening the file.Changes
recording_setup_file_explicit()to open a pcap file at a caller-specified absolute pathrecording-fileis set, falling back to auto-generation otherwiserecording_fs_free()aftercall_free())