fix: preserve recursive call result order - #2768
Open
ryanchou1994 wants to merge 1 commit into
Open
ryanchou1994 wants to merge 1 commit into
ryanchou1994 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Keep return values, exceptions, and call stacks associated with the correct invocation when a spy or fake calls itself recursively. Save each proxy's call index before invoking the wrapped function, including the separate indices of its
withArgsmatches.Fixes #1849.
How to verify - mandatory
npm ci.npm run test-node -- --grep "recursive calls"for the seven regression cases.npm test,npm run lint,npm run prettier:check, andnpm run build.Verified on macOS with Node 26 and Linux with Node 24: 1,563 Node tests, 1,556 Chrome tests, and the WebWorker test pass. The existing 12 Node / 13 browser pending tests remain pending. Lint, formatting, build, package contract checks, and coverage thresholds also pass.
Checklist for author
npm run lintpasses