Fix linting errors from prior PR #208#211
Open
PhysFoley wants to merge 1 commit intosimularium:mainfrom
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 93.01% 93.45% +0.44%
==========================================
Files 106 113 +7
Lines 4936 5299 +363
==========================================
+ Hits 4591 4952 +361
- Misses 345 347 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PhysFoley
force-pushed
the
bugfix/nerdss-write-to-readonly-array
branch
from
f234009 to
2095e40
Compare
Contributor
|
Thanks so much for addressing it. We should have cleaned it up before merging it so thanks for the additional PR. |
meganrm
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a PR to fix the linter errors from my already-merged previous PR #208
Apologies for not catching these before submitting the PR. I am unable to get the linter running locally. Several tries in fresh environments always produce some kind of crash when running "just lint" that seems to originate from a wheel that fails to build.
I used the output of the linter here to fix the offending lines.