instance Show Account also shows sub-accounts - #2687
Draft
thielema wants to merge 1 commit into
Draft
Conversation
Only this way you can see the tree structure of accounts and sub accounts.
thielema
force-pushed
the
instance-show-account
branch
from
August 11, 2026 11:55
980b269 to
15701d1
Compare
Owner
|
Yes, Account is a tree. Yes, it sounds like printing the whole tree will be too noisy ? But I'm not sure how many debug messages print an Account. |
Owner
|
I haven't seen this in action yet. But if it is too noisy, adding elided info like "asubs: (3 subaccounts)" might be enough of a hint to look deeper. Or perhaps it could be sensitive to debug level, showing all subs only at level 9. |
Owner
|
Or, showing them in compact form. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was confused for days because code comments talk about account trees and according functions morally have to deal with trees not individual accounts. However, the type is named
Accountand it does not show sub accounts in debug output.I added showing the sub-accounts to
instance Show Account. But maybe, for some debug situations this is too noisy?