Repository navigation
Fail the required aggregate when any shard fails - #1460
Merged
Merged
Conversation
Under bash -e a failing test before the last && of a list does not end the step, so Focused Linux Silk passed with the native corpus red (push 3ca78ea). Test each shard on its own line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJak9tcQcwEZgNXjANPTiA
This was referenced Oct 11, 2026
julia-script
added a commit
that referenced
this pull request
Oct 18, 2026
Fail the required aggregate when any shard fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Focused Linux Silk" ran
test "$CHAIN" = success && test "$CORPUS" = success && test "$NATIVE_CASES" = successunderbash -e. A failing command before the last&&of a list does not end a-escript, so a red, skipped or cancelled chain, corpus or native-cases shard was ignored whenever the next line passed. The same pattern (test "$CORPUS" = success && test "$SEED" = success) has existed since7ec4ab3(2026-10-10).The fix puts each shard's test on its own line. The
casesline is unchanged: as the script's last command, its status is the step's status.Checked locally with the step's exact script under
bash -e:Workflow-only change. Not a guarded input, so it lands on
selfhostdirectly.Record: runs the hole let through
I scanned every
selfhost.ymlrun created since7ec4ab3through the REST API, looking for a green aggregate while a gated job failed. These landed:selfhostpush of #1449's merge3ca78easelfhostpush of #1412's merge8dd394cc6ef907718311306a9328894a74aStill open, with a green aggregate over a red corpus: #1457 at
c739f8d(run 38183231447).A second form of the hole: a failed "Native N1 from pinned seed" skips the chain and corpus jobs, and the aggregate still passed. Only superseded heads of #1437, #1441, #1446 and #1452 were hit; none of those heads merged.
The 2026-10-10 corpus failures were fixed later: on
3ca78eaonly the four P6 programs fail.🤖 Generated with Claude Code
https://claude.ai/code/session_01SJak9tcQcwEZgNXjANPTiA