Repository navigation
test(crypto): fix boring_provider build after sha384 returns Sha384Hash - #332
Merged
Merged
Conversation
#325 changed sha384() to return Sha384Hash; the boring_provider test (built only with --cfg sigstore_boring_test) still passed it by reference where a byte slice is expected. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
Member
I wish I used some easier test bench than boring... |
jku
approved these changes
Oct 13, 2026
This was referenced Oct 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#325 changed
sha384()to returnSha384Hash. One call incrates/sigstore-crypto/tests/boring_provider.rsstill passed it as&sha384(data)where a&[u8]is expected. That file only compiles under--cfg sigstore_boring_test, so--all-featuresdidn't catch it, and the "Run sigstore-crypto BoringProvider tests" step now fails onmainand on the release PR #313.Fix:
sha384(data).as_bytes().I couldn't run the boring tests locally (BoringSSL needs Go and clang), so this PR's CI step is the verification.
🤖 Generated with Claude Code