Repository navigation
ci: consolidate feature and dependency checks into check-features.py - #320
Merged
Merged
Conversation
jku
marked this pull request as draft
October 7, 2026 08:36
Clean up the slightly bit-rotted feature checking. Remove check-native-tls.sh (and the CI jobs), fold the features into check-features.py: - Check `--examples` in addition to `--lib` and `--bins` across all isolated feature variants, and declare `required-features` on the `conformance_client` and `trust-instance` examples. - Verify that enabling all non-`rustls` features on each workspace crate does not pull `rustls` into normal dependencies. - Add `sigstore-tuf` and `sigstore-trust-root` (`--no-default-features`) to the offline dependency check forbidding `reqwest`, `hyper`, and `tokio`. Removing `check-native-tls.sh` and its matrix job drops running `cargo tree` on macOS and Windows, losing only theoretical coverage for target-specific dependency rules that would pull in `rustls` exclusively on macOS or Windows. Compiling native TLS backends on all OSes remains covered by the `test` matrix job. Co-authored-by: Antigravity / Gemini 4 Argon <noreply@google.com> Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
marked this pull request as ready for review
October 12, 2026 07:46
# Conflicts: # scripts/check-features.py
wolfv
approved these changes
Oct 13, 2026
This was referenced Oct 13, 2026
Closed
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up the slightly bit-rotted feature checking. Remove check-native-tls.sh (and the CI jobs), fold the features into check-features.py:
--examplesin addition to--liband--binsacross all isolated feature variants, and declarerequired-featureson theconformance_clientandtrust-instanceexamples.rustlsfeatures on each workspace crate does not pullrustlsinto normal dependencies.sigstore-tufandsigstore-trust-root(--no-default-features) to the offline dependency check forbiddingreqwest,hyper, andtokio.Removing
check-native-tls.shand its matrix job drops runningcargo treeon macOS and Windows, losing only theoretical coverage for target-specific dependency rules that would pull inrustlsexclusively on macOS or Windows. Compiling native TLS backends on all OSes remains covered by thetestmatrix job.