Skip to content

Cap the heap at the cart-region boundary #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neilrackett wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cap the heap at the cart-region boundary #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions rp/src/memmap_rp.ld
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,14 @@ SECTIONS



/* stack limit is poorly named, but historically is maximum heap ptr */
__StackLimit = ORIGIN(RAM) + LENGTH(RAM) + LENGTH(ROM_IN_RAM);
/* stack limit is poorly named, but historically is maximum heap ptr.
* Must NOT include ROM_IN_RAM: pico-sdk's _sbrk bounds the heap by
* this symbol, and letting it grow past ORIGIN(ROM_IN_RAM) hands the
* cartridge region (the code the m68k executes over the cart bus) to
* malloc -- FatFs LFN buffers then corrupt it at runtime and the ST
* crashes with bombs. Capped at the RAM/cart boundary so malloc
* fails cleanly instead. */
__StackLimit = ORIGIN(RAM) + LENGTH(RAM);
__StackOneTop = ORIGIN(SCRATCH_X) + LENGTH(SCRATCH_X);
__StackTop = ORIGIN(SCRATCH_Y) + LENGTH(SCRATCH_Y);
__StackOneBottom = __StackOneTop - SIZEOF(.stack1_dummy);
Expand Down