docs: fix stale router extension-point description in ARCHITECTURE.md - #149
Open
shrdgn wants to merge 1 commit into
Open
docs: fix stale router extension-point description in ARCHITECTURE.md#149shrdgn wants to merge 1 commit into
shrdgn wants to merge 1 commit into
Conversation
router.route() doesn't exist as the entry point server.py calls, and the "swap in an LLM classifier" framing describes something already shipped (RouterMode.MODEL / router._classify_route). Point both references at the real entry point, route_request(), and describe the classifier as already supported. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EdA4xCCD6tTs2Z1atpfdB7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
docs/ARCHITECTURE.md's "Extension points" section and request-flow diagram both referencedrouter.route()as the entry pointserver.pycalls beforegather_panel, and described an LLM classifier as a future extension ("swap in an LLM classifier behind the sameRouteDecisionreturn type").Both are stale:
server.pydoesn't callrouter.route()— it imports and callsrouter.route_request()(server.py:495), which internally dispatches to either the classifier or the synchronous heuristicroute().RouterMode.MODEL/router._classify_route, documented inREADME.mdwith a full YAML example and covered bytests/test_router.py.The module table one row above (
router.py— "heuristic or model classifier") already got this right; only the "Extension points" prose and the flow diagram were left behind after the classifier shipped. Fixed both references to point at the real entry point and describe the classifier as already supported.How it was tested
ruff check .passes (docs-only change, no code touched)pytest -qpasses (no live network) — no code changed, ran full suite as a sanity checkbench/run.pynumber — not applicableNotes for reviewers
Found via an automated repo-review scheduled task. Docs-only, zero code changes.
Generated by Claude Code