【Grind75Hard】2問目297. Serialize and Deserialize Binary Tree#62
Open
shining-ai wants to merge 2 commits intomainfrom
Open
【Grind75Hard】2問目297. Serialize and Deserialize Binary Tree#62shining-ai wants to merge 2 commits intomainfrom
shining-ai wants to merge 2 commits intomainfrom
Conversation
liquo-rice
reviewed
May 4, 2024
| """ | ||
| if not root: | ||
| return "" | ||
| serial_tree = [] |
Owner
Author
There was a problem hiding this comment.
自分で気づけないので、変数名の指摘は非常にありがたいです。
| while node_queue: | ||
| node = node_queue.popleft() | ||
| if not node: | ||
| serial_tree.append("null") |
There was a problem hiding this comment.
static memberとして、NULL_SYMBOL = "#"などを定義してはどうですか？
Owner
Author
There was a problem hiding this comment.
leetcodeだと定数を使うのを忘れてしまいがちなので、意識的に使うようにします。
| node.right = helper_deserialize(data) | ||
| return node | ||
|
|
||
| root = helper_deserialize(deque(data.split(","))) |
There was a problem hiding this comment.
indexを管理したくなかったら、
it = iter(data.split(","))
next(it)
とする方法もあります。
Owner
Author
There was a problem hiding this comment.
イテレータを使う発想がありませんでした。
dequeする必要がなかったので、分かりやすくなった気がします。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
https://leetcode.com/problems/serialize-and-deserialize-binary-tree