fix: only map customer address if existant, address validation is based on invoice type and VAT registration presence#17
Merged
Conversation
…Validator and CustomerValidator
…VAT registration check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the customer mapping and validation logic to more accurately handle address requirements based on VAT registration and invoice type. The changes ensure that address information is validated and mapped only when appropriate, aligning with business rules and ZATCA requirements.
Customer Address Mapping and Validation:
CustomerMapperso that thePartyobject is always created, and the postal address is only set if address data is provided. This prevents empty address objects from being set when no address is supplied. [1] [2]Validation Logic Improvements:
CustomerValidatorto require address validation if the customer is VAT-registered, regardless of invoice type, or if address data is present. This ensures compliance with ZATCA and business requirements.validateVatRegisteredCustomer, ensuring address is always validated for such customers.validateNonVatCustomer.