Skip to content

Fix mutating path of URL without authority (idempotency, empty path segments)#996

Open
theskim wants to merge 3 commits into
servo:mainfrom
theskim:main
Open

Fix mutating path of URL without authority (idempotency, empty path segments)#996
theskim wants to merge 3 commits into
servo:mainfrom
theskim:main

Improve testing for host, path, query, hash when mutating path

c9a88a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 3, 2026 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

❌ Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@adb8660). Learn more about missing BASE report.

Files with missing lines Patch % Lines
url/src/path_segments.rs 88.88% 2 Missing ⚠️
url/src/lib.rs 96.42% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #996   +/-   ##
=======================================
  Coverage        ?   80.38%           
=======================================
  Files           ?       24           
  Lines           ?     4364           
  Branches        ?        0           
=======================================
  Hits            ?     3508           
  Misses          ?      856           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.