Repository navigation
Align automated reviews with the shared reviewer package - #24
Conversation
Port the common review engine, regression fixtures, and closed adapter checker. Run parity checks alongside the existing validate helper and metadata checks.
There was a problem hiding this comment.
| Intent | System | Craft | Critical | Important | Minor |
|---|---|---|---|---|---|
| PASS | PASS | PASS | 0 | 0 | 0 |
Readiness: ready
Details
Target
Target: PR #24 (261031-dev-session -> main)
Boundary: committed range. Base c68221a, head 4e1fe3c, tree c289e98c7edfe57a01de828d0624f70df591fa25. Uncommitted state: none. Excluded paths: none.
Range: c68221a...4e1fe3c - 10 files changed, 1173 insertions(+), 129 deletions(-)
Commits:
4e1fe3cPreserve docs-only review eligibility through the explicit CI adapterc87cf15Align reviewer instructions with the shared review package6790c99Align summary fixtures with the shared reviewer identity adapter77f184cAlign automated review with shared parity package
Coverage: a single self-review (not independent; no reviewer was dispatched). Read in full: identity.txt, stat.txt, log.txt, pr.json, scripts/check_review_parity.py, scripts/review-parity.json. Read in part: the ci.yml hunk and the first 60 changed lines of diff.patch (summary-gathering and CI-selection hunks of claude-review.yml). Not read in depth: most of the claude-review.yml changes, test_claude_review.py, test_review_parity.py, the fixtures, and the AGENTS.md edits. Intent sources: the PR title and description, and AGENTS.md. No plan or spec file exists.
Axis verdicts
No findings in the parts read, so the readiness is ready. The coverage above is partial.
- Intent: PASS. The adapter manifest, parity checker, CI wiring, and CI-run selection by allowed events and required jobs match the PR description.
- System: PASS. The checker accepts only one of four closed adapter profiles and fails on any slot-count or fingerprint drift. The summary path now checks the proposal against the ledger's disposition events. The CI-run selection requires each required job to succeed, or to be skipped only where the adapter lists it as skippable.
- Craft: PASS. The change adds a self-test that rejects a real review-limit drift, plus unit tests for the checker.
No previous yngwald review exists, so this is not a fresh review pass.
Set aside, open questions, and review gaps
- Set aside: the checker only fingerprints the files in
PACKAGE_FILESand does not execute them. The PR description states that deliberate trade-off. - Open questions: none.
- Gaps: tests were not run in this job. CI (validate) is green on the head SHA. The unread parts listed under Coverage are unassessed. Live issue, reply, and resolve permissions are not exercised, as the PR description states.
Reviewed with: /cr-request 0.0.11 skill · In 0 min 39 sec
Next step: /verify -> /finalize squash
Review cycle summaryReviews: 1 |
Why
Synchronize automated reviewer behavior and safety fixes across the four repositories while retaining project CI and reviewer identities.
What changed
Scope and trade-offs
Local copies share one normalized implementation; explicit adapters cover account, secret name, workflow/input names, CI jobs/events and allowed project skips. PAT permissions are unchanged. ihororlovskyi publishes the configuration; yngwald remains the reviewer.
Blast radius and reversibility
Affects automated PR review, completion and merged summaries. Reverting the workflow/package change restores the previous code; a revert does not remove already published GitHub reviews, issues or replies.
Verification
python3 -m unittest discover -s scripts -p test_claude_review.py-> 75 passed (Ruby 3.4.1); identical reviewed Git tree for the SO integration commit.python3 scripts/check_review_parity.py --self-test-> PASS;python3 -m unittest discover -s scripts -p test_review_parity.py-> 7 passed.actionlintandgit diff --check-> PASS.Rulings
Deferred