Skip to content

Align automated reviews with the shared reviewer package - #24

Merged
ihororlovskyi merged 4 commits into
mainfrom
261031-dev-session
Oct 31, 2026
Merged

ihororlovskyi merged 4 commits into
mainfrom
261031-dev-session

Conversation

@ihororlovskyi

@ihororlovskyi ihororlovskyi commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Why

Synchronize automated reviewer behavior and safety fixes across the four repositories while retaining project CI and reviewer identities.

What changed

  • Use the shared Sonnet 5.5 medium workflow with five reviews, the same gate/override rules, review format, ledger/recovery and merged summary.
  • Check normalized workflow, harness and fixture fingerprints in CI; keep the API-only resolver and read-only model credential boundary.

Scope and trade-offs

Local copies share one normalized implementation; explicit adapters cover account, secret name, workflow/input names, CI jobs/events and allowed project skips. PAT permissions are unchanged. ihororlovskyi publishes the configuration; yngwald remains the reviewer.

Blast radius and reversibility

Affects automated PR review, completion and merged summaries. Reverting the workflow/package change restores the previous code; a revert does not remove already published GitHub reviews, issues or replies.

Verification

  • python3 -m unittest discover -s scripts -p test_claude_review.py -> 75 passed (Ruby 3.4.1); identical reviewed Git tree for the SO integration commit.
  • python3 scripts/check_review_parity.py --self-test -> PASS; python3 -m unittest discover -s scripts -p test_review_parity.py -> 7 passed.
  • actionlint and git diff --check -> PASS.
  • Existing cr-received/cross-cr helper suites -> 13 and 236 passed (one existing skip); actual metadata/manifests/Unicode CI blocks passed.
  • Verify: PASS full tree c289e98c7edfe57a01de828d0624f70df591fa25 2026-10-31 02:22

Rulings

  • R3-F1 ACCEPT: preserve Agilecharts docs-only CI through an exact four-app-job skip allowlist; review fixtures and the other adapters remain strict.
  • Common fixture actor adaptation is shared; assertions are retained.
  • Canonical engine behavior and credential boundaries remain unchanged apart from the explicit CI compatibility adapters.

Deferred

  • Hosted CI and yngwald review 5720136265 completed on the exact current head; review reports 0 findings with explicit partial self-review coverage, alongside the independent local R4 review.
  • Task 8 (outward): merged-summary readback follows merge.
  • Live issue/reply/resolve permissions and merged-summary delivery are not proven by offline fixtures.
  • Required project pre-squash checks precede any merge.

@ihororlovskyi
ihororlovskyi marked this pull request as ready for review October 31, 2026 00:33

@yngwald yngwald left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent System Craft Critical Important Minor
PASS PASS PASS 0 0 0

Readiness: ready

Details

Target

Target: PR #24 (261031-dev-session -> main)

Boundary: committed range. Base c68221a, head 4e1fe3c, tree c289e98c7edfe57a01de828d0624f70df591fa25. Uncommitted state: none. Excluded paths: none.

Range: c68221a...4e1fe3c - 10 files changed, 1173 insertions(+), 129 deletions(-)

Commits:

  • 4e1fe3c Preserve docs-only review eligibility through the explicit CI adapter
  • c87cf15 Align reviewer instructions with the shared review package
  • 6790c99 Align summary fixtures with the shared reviewer identity adapter
  • 77f184c Align automated review with shared parity package

Coverage: a single self-review (not independent; no reviewer was dispatched). Read in full: identity.txt, stat.txt, log.txt, pr.json, scripts/check_review_parity.py, scripts/review-parity.json. Read in part: the ci.yml hunk and the first 60 changed lines of diff.patch (summary-gathering and CI-selection hunks of claude-review.yml). Not read in depth: most of the claude-review.yml changes, test_claude_review.py, test_review_parity.py, the fixtures, and the AGENTS.md edits. Intent sources: the PR title and description, and AGENTS.md. No plan or spec file exists.

Axis verdicts

No findings in the parts read, so the readiness is ready. The coverage above is partial.

  • Intent: PASS. The adapter manifest, parity checker, CI wiring, and CI-run selection by allowed events and required jobs match the PR description.
  • System: PASS. The checker accepts only one of four closed adapter profiles and fails on any slot-count or fingerprint drift. The summary path now checks the proposal against the ledger's disposition events. The CI-run selection requires each required job to succeed, or to be skipped only where the adapter lists it as skippable.
  • Craft: PASS. The change adds a self-test that rejects a real review-limit drift, plus unit tests for the checker.

No previous yngwald review exists, so this is not a fresh review pass.

Set aside, open questions, and review gaps

  • Set aside: the checker only fingerprints the files in PACKAGE_FILES and does not execute them. The PR description states that deliberate trade-off.
  • Open questions: none.
  • Gaps: tests were not run in this job. CI (validate) is green on the head SHA. The unread parts listed under Coverage are unassessed. Live issue, reply, and resolve permissions are not exercised, as the PR description states.

Reviewed with: /cr-request 0.0.11 skill · In 0 min 39 sec
Next step: /verify -> /finalize squash

@ihororlovskyi
ihororlovskyi merged commit 7a96dfc into main Oct 31, 2026
16 checks passed
@ihororlovskyi
ihororlovskyi deleted the 261031-dev-session branch October 31, 2026 00:44
@yngwald

yngwald commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator

Review cycle summary

Reviews: 1
Findings: 0
Critical: 0
Important: 0
Minor: 0
Fixed: 0
Rejected: 0
Deferred: 0
Undetermined: 0
Duration measured: 1/1
Duration total: 39 sec
Duration mean: 39.00 sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants