CPLAT-9497: fix session nav and config test env#31
Merged
Conversation
Keep sessions grouping on tab/shift+tab so g/G can behave like vim-style navigation again: gg jumps to the top and G jumps to the end. Update the sessions help text accordingly and add tests covering gg/G and tab-based group cycling.
Config test popups regressed because isolated env startup no longer had all of the approval bits Claude expects. We were already seeding trust and project onboarding, but recent Claude builds also gate startup on the CLAUDE.md external include approval flags. Update injectProjectTrust to mark: - hasClaudeMdExternalIncludesApproved - hasClaudeMdExternalIncludesWarningShown alongside trust/onboarding, so config-test popups start directly instead of asking the approval question and exiting. Add a focused test covering the injected project state.
Kairo-Kim
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://sendbird.atlassian.net/browse/CPLAT-9497
Summary
g/Gfor vim-style session list navigation (gg→ top,G→ end) and keep group cycling ontab/shift+tabTest plan
go test ./internal/tui -run 'TestSessionsGGJumpsToTop|TestSessionsGJumpsToEnd|TestSessionsTabStillCyclesGroupMode|TestSessionsHelpShowsNavigationAndTabGrouping'go test ./internal/tmux ./internal/tui -run 'TestInjectProjectTrustSetsApprovalFlags|TestBuildConfigTestEnv'go test ./...gg/Gfor top/end andtab/shift+tabfor group changes