Skip to content

CPLAT-9497: fix session nav and config test env#31

Merged
gavin-jeong merged 2 commits into
masterfrom
CPLAT-9497-session-nav-config-test-fixes
Apr 22, 2026
Merged

CPLAT-9497: fix session nav and config test env#31
gavin-jeong merged 2 commits into
masterfrom
CPLAT-9497-session-nav-config-test-fixes

Conversation

@gavin-jeong
Copy link
Copy Markdown
Collaborator

JIRA: https://sendbird.atlassian.net/browse/CPLAT-9497

Summary

  • reserve g/G for vim-style session list navigation (gg → top, G → end) and keep group cycling on tab / shift+tab
  • update sessions help text to make the new navigation/group split explicit
  • restore config test popup startup by seeding the isolated Claude state with CLAUDE.md external include approval flags in addition to trust/onboarding
  • add regression tests for both the session keybinding behavior and isolated config-test env approval seeding

Test plan

  • go test ./internal/tui -run 'TestSessionsGGJumpsToTop|TestSessionsGJumpsToEnd|TestSessionsTabStillCyclesGroupMode|TestSessionsHelpShowsNavigationAndTabGrouping'
  • go test ./internal/tmux ./internal/tui -run 'TestInjectProjectTrustSetsApprovalFlags|TestBuildConfigTestEnv'
  • go test ./...
  • manual: sessions view uses gg/G for top/end and tab/shift+tab for group changes
  • manual: config test popup opens without the approval question and stays usable

Keep sessions grouping on tab/shift+tab so g/G can behave like vim-style
navigation again: gg jumps to the top and G jumps to the end. Update the
sessions help text accordingly and add tests covering gg/G and tab-based
group cycling.
Config test popups regressed because isolated env startup no longer had
all of the approval bits Claude expects. We were already seeding trust and
project onboarding, but recent Claude builds also gate startup on the
CLAUDE.md external include approval flags.

Update injectProjectTrust to mark:
- hasClaudeMdExternalIncludesApproved
- hasClaudeMdExternalIncludesWarningShown

alongside trust/onboarding, so config-test popups start directly instead of
asking the approval question and exiting. Add a focused test covering the
injected project state.
@gavin-jeong gavin-jeong merged commit 5f91f61 into master Apr 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants