Skip to content

fix: use createdAt parameter instead of time.Now() in NewProposal#3030

Merged
pompon0 merged 2 commits intomainfrom
wen/handle_timestamp
Mar 6, 2026
Merged

fix: use createdAt parameter instead of time.Now() in NewProposal#3030
pompon0 merged 2 commits intomainfrom
wen/handle_timestamp

Conversation

@wen-coding
Copy link
Contributor

@wen-coding wen-coding commented Mar 6, 2026

Summary

  • NewProposal accepted a createdAt time.Time parameter but ignored it, always using time.Now().
  • Fix: use the createdAt parameter as intended so callers control the timestamp.
  • All existing callers pass time.Now(), so runtime behavior is unchanged.

Test plan

  • All existing autobahn tests pass (no behavioral change).

Made with Cursor

NewProposal accepted a createdAt argument but ignored it, always using
time.Now(). This has been the case since the initial migration from
sei-v3. Use the parameter as intended so callers control the timestamp.

All existing callers pass time.Now(), so runtime behavior is unchanged.

Made-with: Cursor
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 6, 2026, 2:49 PM

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.25%. Comparing base (b866a23) to head (90c3c19).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3030      +/-   ##
==========================================
- Coverage   58.27%   58.25%   -0.02%     
==========================================
  Files        2077     2077              
  Lines      171308   171292      -16     
==========================================
- Hits        99828    99785      -43     
- Misses      62583    62608      +25     
- Partials     8897     8899       +2     
Flag Coverage Δ
sei-chain-pr 77.94% <100.00%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/internal/autobahn/types/proposal.go 85.01% <100.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 enabled auto-merge (squash) March 6, 2026 10:38
@pompon0 pompon0 merged commit 42971a4 into main Mar 6, 2026
41 of 42 checks passed
@pompon0 pompon0 deleted the wen/handle_timestamp branch March 6, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants