fix: use createdAt parameter instead of time.Now() in NewProposal#3030
Merged
fix: use createdAt parameter instead of time.Now() in NewProposal#3030
Conversation
NewProposal accepted a createdAt argument but ignored it, always using time.Now(). This has been the case since the initial migration from sei-v3. Use the parameter as intended so callers control the timestamp. All existing callers pass time.Now(), so runtime behavior is unchanged. Made-with: Cursor
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3030 +/- ##
==========================================
- Coverage 58.27% 58.25% -0.02%
==========================================
Files 2077 2077
Lines 171308 171292 -16
==========================================
- Hits 99828 99785 -43
- Misses 62583 62608 +25
- Partials 8897 8899 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
masih
approved these changes
Mar 6, 2026
pompon0
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewProposalaccepted acreatedAt time.Timeparameter but ignored it, always usingtime.Now().createdAtparameter as intended so callers control the timestamp.time.Now(), so runtime behavior is unchanged.Test plan
Made with Cursor