do not create receipts for invisible txs#2997
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2997 +/- ##
==========================================
+ Coverage 58.25% 58.41% +0.15%
==========================================
Files 2077 2110 +33
Lines 171294 175022 +3728
==========================================
+ Hits 99786 102231 +2445
- Misses 62614 63765 +1151
- Partials 8894 9026 +132
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for _, deferredInfo := range evmTxDeferredInfoList { | ||
| txHash := common.BytesToHash(deferredInfo.TxHash) | ||
| if deferredInfo.Error != "" && txHash.Cmp(ethtypes.EmptyTxsHash) != 0 { | ||
| if !k.GetNonceBumped(ctx, deferredInfo.TxIndex) { |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
arajasek
approved these changes
Mar 2, 2026
codchen
force-pushed
the
tony/no-receipt-for-no-nonce-bump
branch
from
e8ea49f to
f3047ff
Compare
stevenlanders
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Historically we've been creating artificial receipts for transactions that fail ante handler (i.e. before the tx even enters the EVM). This creates inconsistency in the case where a transaction fails in a way that doesn't bump nonce (which would make the transaction invisible from RPC responses). This PR addresses that inconsistency by not creating receipts for transactions that don't bump nonce.
Testing performed to validate your change
unit tests