[giga] remove Snapshot() call in Prepare()#2957
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
stevenlanders
approved these changes
Feb 23, 2026
giga/deps/xevm/state/statedb.go
Outdated
| coinbaseEvmAddress: feeCollector, | ||
| } | ||
| s.Snapshot() // take an initial snapshot for GetCommitted | ||
| if k.ShouldUseRegularStore() { |
Contributor
There was a problem hiding this comment.
eventually for performance/clarity it might be good to have a way to only check these kind of flags initially when setting handlers (like set a s.Snapshot handler at init/creation). This is fine - just thinking out loud.
Collaborator
Author
There was a problem hiding this comment.
@stevenlanders i think that change was due to my stale local main. Rebased and this PR is just a one-liner
codchen
force-pushed
the
tony/prepare-no-snapshot
branch
2 times, most recently
from
67efdc2 to
dfe9ee6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2957 +/- ##
==========================================
- Coverage 58.25% 58.25% -0.01%
==========================================
Files 2077 2077
Lines 171295 171294 -1
==========================================
- Hits 99787 99786 -1
Misses 62609 62609
Partials 8899 8899
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
arajasek
approved these changes
Mar 5, 2026
codchen
force-pushed
the
tony/prepare-no-snapshot
branch
from
dfe9ee6 to
656463c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
The Snapshot() call would return a
revnumber for potentialRevert(rev)calls to revert to. However theSnapshotcall inPreparehas itsrevvalue discarded, so it isn't useful from a reverting perspective. The other side effects, like creating another nested layer of CacheKV, is also meaningless under the context of EVM (there will just be a layer of CacheKV with zero dirty values). So it can be removed in theory.Removing it resulted in a 1k increase in theoretical tps (from 20k to 21k)
Testing performed to validate your change
existing tests should still stand