Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the smallest shared validator used by generated routes, then tests generic required-parameter and paginator behavior without depending on
access_methods.listcontinuing to require a filter.Evidence
access_methods.listschema.After: fixed test configuration covers empty and pagination-only rejection, filtered acceptance, rejection before requests, unpaginated validation, and all paginator entrypoints.
npm run typecheck— passedbundle exec rspec/ fullrake— not run: clean dependency installation requires native extension compilation, but the sandbox denied reading/usr/include/stdc-predef.h.npm run generategenerated the expected route changes; its post-generate Ruby formatter could not run for the same missing bundle. Unrelated generated resource formatting changes were reverted.Merge Danger
Door: two-way
Blast Radius: request validation
All generated at-least-one guards now delegate to one equivalent helper. Disabling that helper makes the direct validation and paginator specs stop rejecting invalid requests.