Repository navigation
fix: Return nil for unparseable date fields instead of raising on read - #581
Merged
Merged
Conversation
Date accessors called Time.parse on whatever the API sent, so an epoch integer raised TypeError and an empty or malformed string raised ArgumentError at attribute read time, far from the request that produced the value. Parse only strings and return nil when the string is not a date, matching the nil an absent date already reads as. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQW83gyXeUG61RDrHEky97
razor-x
force-pushed
the
claude/ruby-sdk-audit-xbhaia-date-accessor
branch
from
November 5, 2026 20:01
ed91e29 to
9e36bbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SDK audit finding M10 (third part).
date_accessorappliedTime.parseunconditionally, so an epoch integer in any Time-typed field raisedTypeErrorand an empty or malformed string raisedArgumentErrorat attribute-read time, far from the request that produced the value.Fix
parse_datetimeparses only Strings and returns nil when the string is not a date, which is what an absent date already reads as (@return [Time, nil]on optional dates). A value the API promised as a datetime but did not deliver is unusable as aTimeeither way; returning nil keeps the read from crashing an unrelated code path.Tests
spec/resources/base_resource_spec.rb: missing, empty, non-date string, and epoch integer values all read as nil; a valid ISO string still parses.Revert-check against
main: 3 failures,ArgumentErrortwice andTypeErroronce fromTime.parse.🤖 Generated with Claude Code
https://claude.ai/code/session_01SQW83gyXeUG61RDrHEky97
Generated by Claude Code