[razor-x]

Problem

SDK audit finding M3. A 2xx with an unexpected envelope (proxy rewrite, gateway maintenance page with a JSON content type, response-key rename) escaped the SDK's error hierarchy: generated routes did res.body["device"] and the resource loader raised a bare NoMethodError on nil or String, or returned nil silently. A 3xx passed straight through, since Faraday's RaiseError only covers 400–599, so a redirecting endpoint yielded nil instead of an error. The action-attempt poll crashed the same way mid-wait, and the paginator silently ended iteration when the pagination object was missing.

Fix

Ported from seamapi/python#638 and seamapi/php#475, with the same message shape as the other three SDKs:

Seam returned an invalid response for /devices/get: expected "device", which the response does not contain
Seam returned an invalid response for /devices/get: expected "device", got String instead of a response object
Seam returned an invalid response for /devices/list: expected "devices", got Hash instead of a list
Seam returned an invalid response for /devices/get: expected "device", got a 302 response instead of a success response
Seam returned an invalid response for /devices/list: expected "pagination", got String instead of a pagination object

• New Seam::Http::InvalidResponseError < Seam::Error with path and response_key.
• BaseResource.from_http_response(res, key, path) and .list_from_http_response(res, key, path) read the Faraday response, check the status, body shape, key, and object-versus-list, and hand the value to the existing load_from_response, which keeps its current meaning for nested and optional values.
• Template change: every generated route becomes a single Seam::Resources::Device.from_http_response(res, "device", "/devices/get") call, choosing the list form from the blueprint's resource_list response type. Regenerated against current main with zero drift.
• ActionAttemptResolver polls through ActionAttempt.from_http_response. The paginator validates the pagination envelope itself, so a list route that returns no pagination raises instead of silently stopping.

A 2xx whose body is declared JSON but does not parse still raises Faraday::ParsingError from Faraday's JSON middleware, as before; that case is pinned in the spec.

Tests

New spec/seam_client/invalid_response_spec.rb (WebMock): missing key, wrong key, null body, string body, plain text, non-object under key, non-list under list key, 302, malformed poll response mid-wait, missing and non-object pagination through create_paginator. Every message is pinned exactly. seam_error_spec.rb lists the new class.

Revert-check against main: 11 failures, with the audit's symptoms (undefined method 'each' for nil, undefined method '[]' for nil, and "nothing was raised" for the redirect and pagination cases).

🤖 Generated with Claude Code

https://claude.ai/code/session_01SQW83gyXeUG61RDrHEky97