Gene Finder#8
Open
leoliuuu wants to merge 2 commits into
Open
Conversation
SeunginLyu
reviewed
Oct 8, 2017
SeunginLyu
left a comment
SeunginLyu
left a comment
There was a problem hiding this comment.
It looks good overall! The only suggestion I have is that adding more custom unit tests would be helpful for making sure that your functions all run correctly or not! (strongly recommend doing so for future mini projects)
| @@ -2,7 +2,7 @@ | |||
| """ | |||
| YOUR HEADER COMMENT HERE | |||
There was a problem hiding this comment.
In future mini projects, please leave a header comment that describes what this code is about. It's going to help you a lot when the code base gets large.
| YOUR HEADER COMMENT HERE | ||
|
|
||
| @author: YOUR NAME HERE | ||
| @author: |
There was a problem hiding this comment.
Please write your name. It's like writing your name for any other quizzes or projects.
| stop_codons = ["TAG", "TAA","TGA"] | ||
| for i in range(0,len(dna),3): | ||
| codon = dna[i:i+3] | ||
| for stop in stop_codons: |
| """ | ||
| # TODO: implement this | ||
| pass | ||
| return [i for j in range(0,3) for i in find_all_ORFs_oneframe(dna[j:])] |
| import doctest | ||
| doctest.testmod() | ||
| # import doctest | ||
| # # doctest.testmod() |
There was a problem hiding this comment.
please remove comments for final code submission
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.