Better testing

[Daenyth]

• Add tox.ini
• Change handmade test runner to pytest
  • Add a conftest.py with a pytest plugin adding a CLI arg flag.
  • The conn fixture can examine the contents of that arg flag to decide whether to run tests on mockthink connection, rethink connection, or both

[Daenyth]

WIP tox.ini

[tox]
envlist = py27 py35
[testenv]
deps =
    pytest
    py27: mock
commands = py.test {posargs}

[scivey]

what would a basic pytest setup to replace this look like? I'm assuming we'd need to write some kind of adapter.

[Daenyth]

It's been a while but IIRC you have a custom test runner so you can on cli instruct it to use either real rethink or mockthink as the connection object?

It will be a small pytest plugin (defined in a conftest.py) as I describe above.

The tests would be changed to accept a connection fixture as a parameter, the fixture being also defined in conftest.py and using the cli argument that the plugin provides, so that you can do py.test --rethink-conn foobar tests/ or so

[Daenyth]

http://doc.pytest.org/en/latest/writing_plugins.html

[Daenyth]

http://doc.pytest.org/en/latest/fixture.html

[scivey]

@Daenyth sounds like you just volunteered!

[Daenyth]

When I have time.

[scivey]

@Daenyth did your merged-in PR cover this?

[Daenyth]

Yes, we can close this

[naman-d98]

Is this mockthink lib compatible with python 2.7??