POC - skglm GPU support - #149
Closed
Badr-MOUFAD wants to merge 52 commits into
Closed
Badr-MOUFAD wants to merge 52 commits into
Badr-MOUFAD wants to merge 52 commits into
Conversation
Badr-MOUFAD
marked this pull request as draft
March 14, 2023 10:34
mathurinm
reviewed
Mar 14, 2023
| from skglm.gpu.utils.host_utils import compute_obj, eval_opt_crit # noqa | ||
|
|
||
|
|
||
| class JaxSolver: |
Collaborator
There was a problem hiding this comment.
In order to test the design choices, can you call this FISTAJax and make it modular (ie pass an objective function directly) ? and same for other solvers
4 of 5 tasks
Collaborator
Author
|
close in favor of #155 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This explores adding GPU support to the package.
It implements FISTA solver for Lasso problem using
JAXCuPyNumba.cudaRefer to README to install and play around with the solvers