Conversation
ricrogz
requested review from
ethan-schrodinger and
rachelnwalker
as code owners
October 27, 2025 13:09
ethan-schrodinger
approved these changes
Oct 27, 2025
ricrogz
enabled auto-merge
October 27, 2025 15:38
Collaborator
|
Why do we need this? I thought the plan was to continue to use cmake for the sketcher build even as a submodule |
Contributor
Author
SKETCH-2593. There's things included from here all over the place. |
rachelnwalker
approved these changes
Feb 27, 2026
rachelnwalker
left a comment
rachelnwalker
left a comment
Collaborator
There was a problem hiding this comment.
@ricrogz @cdvonbargen I realize this slept through the cracks a while ago - do we still need this as apart of SKETCH-2593?
Collaborator
|
No, I think we should close this. We can resurrect if Archie's work doesn't pan out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of SKETCH-2593. When the rdkit_extensions or sketcher headers are included in other Core Suite files, the export macros clash with the ones already defined in the suite. This checks for the existence of the macros before attempting to define them. It also allows overriding them, in case anyone needs to do thath.