Skip to content

fix(ARTESCA-17607): fix Rubrik bucket name UX issues (points 2-6)#1214

Merged
bert-e merged 1 commit into
development/4from
bugfix/ARTESCA-17607-rubrik-bucket-ux-fixes
May 28, 2026
Merged

fix(ARTESCA-17607): fix Rubrik bucket name UX issues (points 2-6)#1214
bert-e merged 1 commit into
development/4from
bugfix/ARTESCA-17607-rubrik-bucket-ux-fixes

Conversation

@damiengillesscality

@damiengillesscality damiengillesscality commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes points 2–6 from ARTESCA-17607 — UX issues on the bucket name field and form validation in the Rubrik ISV assistant.

  • Point 2 — Error message discrepancy: {N} in the Joi message string was treated as a Joi template variable and resolved to empty, producing "must end with -rubrik-". Replaced with literal <number> in both string.min and string.pattern.name messages.
  • Point 3 — Help text visibility: Wired helpText from fieldOverrides.bucketName through buildFieldsBucketArrayFieldBucketFieldFormGroup.help so the format requirement renders as visible text below the field instead of being hidden behind the IconHelp tooltip.
  • Point 4 — Tooltip font size: Wired tooltip from fieldOverrides.bucketName through the same chain so the platform-specific tooltip (using ListItem, consistent with other fields) is used instead of the fallback plain <Text> tooltip.
  • Point 5 — "an unique": Fixed "Choose an unique name""Choose a unique name" in defaultBucketNameTooltip.
  • Point 6 — Immutable Backup help text: Updated to "Enables object lock on the bucket, making backups permanent and unchangeable.".

Test plan

  • In the Rubrik ISV assistant, enter a bucket name shorter than 3 chars — error should read Bucket name must end with -rubrik-<number> (e.g. my-archive-rubrik-0)
  • Enter a bucket name without the -rubrik-<N> suffix — same error message
  • Verify helper text Must end with -rubrik-<number> (e.g. my-archive-rubrik-0) is visible below the bucket name field without opening any tooltip
  • Verify the tooltip font matches other fields (uses ListItem structure)
  • Check the Immutable Backup toggle shows the updated helper text
  • Run unit tests: npx jest --testNamePattern="rubrik|Rubrik"

🤖 Generated with Claude Code

…ints 2-6)

- Point 2: fix Joi error message template — {N} was treated as a Joi variable
  and resolved to empty; replaced with literal <number> in both string.min and
  string.pattern.name messages so the full error always shows
- Point 3: wire helpText from fieldOverrides through buildFields → BucketArrayField
  → BucketField → FormGroup so it renders as visible helper text below the field
- Point 4: wire tooltip from fieldOverrides through the same chain so the platform
  tooltip (using ListItem) is used instead of the default Text-based tooltip,
  matching the font size of other fields
- Point 5: fix 'an unique' → 'a unique' in defaultBucketNameTooltip
- Point 6: update Immutable Backup helper text to
  'Enables object lock on the bucket, making backups permanent and unchangeable.'

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bert-e

bert-e commented May 28, 2026

Copy link
Copy Markdown
Contributor

Hello damiengillesscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented May 28, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@damiengillesscality

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented May 28, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@claude

claude Bot commented May 28, 2026

Copy link
Copy Markdown

LGTM

Review by Claude Code

@bert-e

bert-e commented May 28, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/4

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1
  • development/2.2
  • development/3.0
  • development/3.1
  • development/3.2
  • development/4.0
  • development/4.1
  • development/4.2

Please check the status of the associated issue ARTESCA-17607.

Goodbye damiengillesscality.

The following options are set: approve

@bert-e bert-e merged commit f2f21fb into development/4 May 28, 2026
15 of 16 checks passed
@bert-e bert-e deleted the bugfix/ARTESCA-17607-rubrik-bucket-ux-fixes branch May 28, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants