fix(ARTESCA-17607): fix Rubrik bucket name UX issues (points 2-6)#1214
Conversation
…ints 2-6)
- Point 2: fix Joi error message template — {N} was treated as a Joi variable
and resolved to empty; replaced with literal <number> in both string.min and
string.pattern.name messages so the full error always shows
- Point 3: wire helpText from fieldOverrides through buildFields → BucketArrayField
→ BucketField → FormGroup so it renders as visible helper text below the field
- Point 4: wire tooltip from fieldOverrides through the same chain so the platform
tooltip (using ListItem) is used instead of the default Text-based tooltip,
matching the font size of other fields
- Point 5: fix 'an unique' → 'a unique' in defaultBucketNameTooltip
- Point 6: update Immutable Backup helper text to
'Enables object lock on the bucket, making backups permanent and unchangeable.'
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Hello damiengillesscality,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
|
/approve |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: The following options are set: approve |
|
LGTM |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARTESCA-17607. Goodbye damiengillesscality. The following options are set: approve |
Summary
Fixes points 2–6 from ARTESCA-17607 — UX issues on the bucket name field and form validation in the Rubrik ISV assistant.
{N}in the Joi message string was treated as a Joi template variable and resolved to empty, producing"must end with -rubrik-". Replaced with literal<number>in bothstring.minandstring.pattern.namemessages.helpTextfromfieldOverrides.bucketNamethroughbuildFields→BucketArrayField→BucketField→FormGroup.helpso the format requirement renders as visible text below the field instead of being hidden behind the IconHelp tooltip.tooltipfromfieldOverrides.bucketNamethrough the same chain so the platform-specific tooltip (usingListItem, consistent with other fields) is used instead of the fallback plain<Text>tooltip."Choose an unique name"→"Choose a unique name"indefaultBucketNameTooltip."Enables object lock on the bucket, making backups permanent and unchangeable.".Test plan
Bucket name must end with -rubrik-<number> (e.g. my-archive-rubrik-0)-rubrik-<N>suffix — same error messageMust end with -rubrik-<number> (e.g. my-archive-rubrik-0)is visible below the bucket name field without opening any tooltipnpx jest --testNamePattern="rubrik|Rubrik"🤖 Generated with Claude Code