Skip to content

🔧 migrate code review to copilot-instructions flow#399

Merged
bert-e merged 3 commits into
development/1from
feature/S3UTILS-240/copilot-review-flow
Jun 17, 2026
Merged

🔧 migrate code review to copilot-instructions flow#399
bert-e merged 3 commits into
development/1from
feature/S3UTILS-240/copilot-review-flow

Conversation

@DarkIsDude

Copy link
Copy Markdown
Contributor

Summary

  • Replace .claude/skills/review-pr/SKILL.md with .github/copilot-instructions.md following the new copilot review flow
  • Update review.yml to use scality/workflows@v2.8.3 and add labeled/unlabeled PR trigger types

Test plan

  • Verify the Code Review workflow triggers on PR open/synchronize/label events
  • Confirm the criteria table in copilot-instructions.md is used by the automated review

Issue: S3UTILS-240

@bert-e

bert-e commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Hello darkisdude,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue S3UTILS-240 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.18.0

Please check the Fix Version/s of S3UTILS-240, or the target
branch of this pull request.

@DarkIsDude DarkIsDude requested review from a team, SylvainSenechal and benzekrimaha June 16, 2026 14:31
Comment thread .github/workflows/review.yml Outdated
Comment thread .github/workflows/review.yml Outdated
Comment thread .github/workflows/review.yml
@bert-e

bert-e commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.94%. Comparing base (482a298) to head (5176008).
⚠️ Report is 3 commits behind head on development/1.

Additional details and impacted files
@@              Coverage Diff               @@
##           development/1     #399   +/-   ##
==============================================
  Coverage          44.94%   44.94%           
==============================================
  Files                 88       88           
  Lines               6459     6459           
  Branches            1353     1353           
==============================================
  Hits                2903     2903           
  Misses              3510     3510           
  Partials              46       46           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DarkIsDude DarkIsDude self-assigned this Jun 16, 2026
Comment thread .github/workflows/review.yml Outdated
@DarkIsDude

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1

The following branches have NOT changed:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.16
  • development/1.17
  • development/1.4
  • development/1.7

This pull request did not target the following hotfix branch(es) so they
were left untouched:

  • hotfix/1.14.0

Please check the status of the associated issue S3UTILS-240.

Goodbye darkisdude.

The following options are set: approve

@bert-e bert-e merged commit 5176008 into development/1 Jun 17, 2026
15 checks passed
@bert-e bert-e deleted the feature/S3UTILS-240/copilot-review-flow branch June 17, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants