Repository navigation
patch: confine Received timestamp extraction to headers - #749
Draft
OllieinCanada wants to merge 1 commit into
Draft
OllieinCanada wants to merge 1 commit into
OllieinCanada wants to merge 1 commit into
Conversation
Only CRLF header separators were recognized, so LF-normalized messages without a Received header could take their received date from body text. Case-sensitive field matching could also skip the topmost header and use an older timestamp from a lower Received field. Stop scanning at the first empty LF or CRLF line and match the exact field name without ASCII case sensitivity. Preserve folded headers, the invalid-topmost fallback and the message body. Add offline regressions through the helper and email parser, including literal expected timestamps and body preservation checks. Fixes: 49a4034 ("embargo: use trusted time from Received header") Signed-off-by: Ollie Slapinski <oliverslapinski@hotmail.com>
OllieinCanada
marked this pull request as draft
October 26, 2026 03:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LF-normalized mail could obtain its Received timestamp from body text and skip mixed-case topmost headers. Stop at the header boundary and match the field name case-insensitively, preserving folding and invalid-topmost fallback.
Offline regressions fail before the repair and pass afterward. Rust 1.90.0: make check-pr passed; 1,151 tests passed, two ignored; formatting and three Clippy profiles passed. The inherited RUST_LOG override was unset. No schema changes or historical data rewrites.
DRAFT: required local Sashiko model self-review is incomplete because provider authentication failed. No clean local review is claimed. Keep as draft until the required review completes and findings are addressed.
Base: d7c69ae
Head: d5396b5