Repository navigation
nntp: preserve checkpoints after failed article fetches - #748
Draft
OllieinCanada wants to merge 1 commit into
Draft
OllieinCanada wants to merge 1 commit into
OllieinCanada wants to merge 1 commit into
Conversation
The ingestor identifies missing articles by searching error text for 423. An error for article 1423 therefore looks like a permanent gap even when the server returned 400. A connection closing before the dot terminator also returns a partial article as a successful fetch. Carry the actual ARTICLE status in a typed error and only skip a real 423 below the tip. Reject EOF and unterminated response lines before restoring the connection. Keep failed fetches out of the ingestion pipeline so its checkpoint remains retryable. Add offline transport and checkpoint regressions, including successful retries and the existing real-gap behavior below and at the server tip. Fixes: cf9f660 ("Implement basic NNTP Ingestor and Client") Fixes: 6e2601e ("fix(ingestor): robust NNTP fetching with gap handling") Signed-off-by: Ollie Slapinski <oliverslapinski@hotmail.com>
OllieinCanada
marked this pull request as draft
October 26, 2026 03:39
Member
|
Hey! For this and other PRs you posted: please, make it clear what real problem it solves and why it's an important problem to be solved, e.g. how it affects real users. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Article 1423 receiving status 400 was mistaken for a permanent gap; EOF could return a partial article as success. Use typed status codes and require complete responses, preserving retry checkpoints and genuine-gap handling.
Offline regressions fail before the repair and pass afterward. Rust 1.90.0: make check-pr passed; 1,152 tests passed, two ignored; formatting and three Clippy profiles passed. The inherited RUST_LOG override was unset. No schema changes or historical data rewrites.
DRAFT: required local Sashiko model self-review is incomplete because provider authentication failed. No clean local review is claimed. Keep as draft until the required review completes and findings are addressed.
Base: d7c69ae
Head: 86c8abd