Repository navigation
maintainers: match wildcard parents in single-level globs - #746
Draft
OllieinCanada wants to merge 1 commit into
Draft
OllieinCanada wants to merge 1 commit into
OllieinCanada wants to merge 1 commit into
Conversation
The single-level directory shortcut treats everything before the final star as a literal prefix. Patterns such as arch/*/net/* and arch/*/events/* therefore never match source files, omitting the BPF and performance-events sections from subsystem attribution. Use the shortcut only for literal parent directories. Let the existing glob matcher handle wildcard parents while preserving component boundaries and the existing specificity ranking. Add offline regressions for matching, exclusions and parsed subsystem attribution. Both tests fail against the previous compiler. Fixes: d0889e3 ("ai: add localized vector space search and subsystem detection") Signed-off-by: Ollie Slapinski <oliverslapinski@hotmail.com>
Sashiko review✓ No issues found across 1 commit. |
OllieinCanada
marked this pull request as draft
October 25, 2026 20:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #745.
MAINTAINERS patterns such as arch//net/ and arch//events/ fail because the single-level directory shortcut treats wildcard parents as literal prefixes. Restrict the shortcut to literal parents and use the existing glob matcher otherwise.
Rust 1.90.0: both new offline regressions fail before the fix and pass afterward. All 13 maintainer-index tests pass. Full make check-pr passed: 1150 tests passed, two ignored; formatting and three Clippy profiles passed. The inherited RUST_LOG override was unset.
No schema changes or historical data rewrites.
DRAFT: required local model self-review is incomplete because provider authentication failed. No clean local model review is claimed. Keep as draft until the required review completes and findings are addressed.