Fix default config for offline plot first#216
Open
eholic wants to merge 1 commit into
Open
Conversation
Collaborator
|
I would support this but I'll leave the decision up to @santosjorge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apologize my last imperfect PRs first. It relates to issue #210 again. cufflinks(fec61cd) without chart_studio may still need
cufflinks.go_offline()due to default config here.cufflinks/cufflinks/auth.py
Line 24 in fec61cd
However I edited some default values, it should be discussed by maintainers.
Also, I should mention former cufflinks users may need to clear or review
~/.cufflinks/.config.