Adds documentation and violin plots!#107
Conversation
|
Thank you @jpoles1 for this. It seems there is a lot going on on this PR. I see what you did with the Either these methods need to be called separately (as That is why I previously suggested that I was going to give it a go with the Regarding the documentation - thank you for this. I was working with some guys that were developing a new doc generator that looked very promising, but I may go with Sphinx until then. Let me check the doc implementation you have here next week - and perhaps we can extract only that commit from this PR. |
|
@santosjorge any update on this? Because I think cufflinks would benefit greatly from proper documentation. |
I think the documentation is the more significant contribution here. Fixes #104.
That said, I do like violin plots and use them often in my research. They are added here using figure_factory. I hope that this code is up to snuff and is reasonably in line with the style/organization of the rest of the codebase. Happy to tune this up further however you'd like @santosjorge. Fixes #50.
Normally I'd try and keep these two contributions separate, but I wanted to use the documentation in order to better develop the violin plots, so I ended up working on them at the same time, entangling their commits. That's my bad.