Repository navigation
Add HSTS policy validation for includeSubDomains and preload - #72
Open
goosvorbook wants to merge 2 commits into
Open
goosvorbook wants to merge 2 commits into
goosvorbook wants to merge 2 commits into
Conversation
The analyze_hsts function was added to parse HSTS header values, validate directives, and return findings. It checks for issues related to max-age, includeSubDomains, and preload directives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HSTS policy validation
Summary
This PR extends the
Strict-Transport-Securitycheck to validate the HSTS policy, not just the presence of the header.Changes
max-agemax-age=0includeSubDomainsis missingpreloadas informationalExample
For:
Strict-Transport-Security: max-age=31536000shcheck now reports: