fix(rx): isolate dsh launch overlay per provider - #259
Merged
Merged
Conversation
The dsh settings overlay and launch patch lived at a single ~/.recall/dsh/ path shared by every rxd launch. dsh watches the overlay and hot-reloads it, so starting a second rxd session with a different provider rewrote the routes, default model, and permission preset of every running session, and in-session settings edits were clobbered on the next launch. Write the overlay under ~/.recall/dsh/<provider>/ instead. Provider ids are already restricted to [A-Za-z0-9_-], so the segment cannot escape the directory. Same-provider sessions still share one overlay; that is accepted, since the default launch is yolo and a later launch corrects the preset. Signed-off-by: samzong <samzong.lu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
~/.recall/dsh/<provider>/instead of a single shared~/.recall/dsh/path.tokenerandopenrouterlaunches produce separate overlays with independent routes and default providers.crates/rx/DESIGN.mdto state the per-provider overlay location.Why
rxdsession with a different provider rewrote the routes, default model, and permission preset of every running session, and settings edited inside a session were clobbered on the next launch.[A-Za-z0-9_-]before reaching the launch path, so the new segment cannot escape the directory.Validation
cargo test -p rxmake check