Fix whole-second timestamp ordering in the SQLite store#269
Merged
Conversation
…n SQLite datetime.isoformat() omits the fractional part when microsecond == 0, so the ~1e-6 of writes landing on a whole second produced '...59Z', which sorts lexicographically AFTER every '...59.000123Z' in the same second — corrupting created_at/updated_at ordering (surfaced as rare crashes in offline benchmark replays). timespec='microseconds' pins the format. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by a probe run during round-2 benchmark work:
_utc_now_iso()drops the fractional part when a write lands on exactly a whole second (~1e-6 of inserts), and the resulting...59Zstring sorts lexicographically after every...59.000123Zsibling — corrupting timestamp ordering.timespec="microseconds"pins the format; regression test included.🤖 Generated with Claude Code