Develop - Optimization

[sameerasw]

This pull request introduces several improvements and refactorings to BLE and network connection management, device name handling, and service lifecycle in the AirSync app. The main focus is on streamlining BLE sync settings observation, reducing blocking calls, enhancing device name matching logic, and clarifying the separation between BLE and Wi-Fi connections. It also updates how device discovery and notification updates are handled to be more efficient and responsive.

BLE and DataStore Management:

• Refactored BleGattServer to observe BLE sync enabled state via a coroutine and a cached variable (isBleSyncEnabled), replacing repeated blocking reads from DataStoreManager. This improves responsiveness and efficiency when checking BLE sync status. [1] [2] [3]
• Added a static getContext() method to AirSyncApp for easier access to the application context when needed.

Device Name Handling and Matching:

• Updated BleTransportBridge.sendDeviceName() to use a persisted device name from DataStoreManager if available, falling back to a utility method, and made the context parameter optional.
• Improved device name matching in WakeupHandler by normalizing names (trimming, lowercasing, and replacing special characters) for more reliable connection and key retrieval.

Service and Notification Lifecycle:

• Modified AirSyncService to cache the last connected device and observe changes via a coroutine, reducing redundant blocking calls and ensuring notifications stay updated in real time. [1] [2] [3]
• Refactored device discovery and wakeup logic in AirSyncService to use coroutines for non-blocking initialization and state changes. [1] [2]

Wi-Fi and BLE Connection Handling:

• Clarified logic to ensure Wi-Fi WebSocket disconnects do not affect BLE connections, and improved detection of Wi-Fi connection status before disconnecting or reconnecting. [1] [2] [3]
• Updated auto-reconnect and disconnect logic in WebSocketUtil to better distinguish between Wi-Fi and BLE, avoid unnecessary reconnects when authenticated via BLE, and use coroutines for state updates. [1] [2] [3] [4] [5] [6]

Other Improvements:

• Enhanced device matching logic in WakeupHandler to handle edge cases and fallback scenarios more gracefully, including single-device environments.
• Minor adjustments to ensure discovery broadcasts and auto-reconnects are only triggered when appropriate, considering both BLE and Wi-Fi states.

These changes collectively improve the app’s efficiency, reliability, and maintainability, especially around BLE and Wi-Fi connection management.