Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 66.75% 66.81% +0.06%
==========================================
Files 96 96
Lines 7973 7988 +15
==========================================
+ Hits 5322 5337 +15
Misses 2650 2650
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a completed input still has buffered values,
Zip2–Zip6can emit the final tuple and then deadlock during completion. TheirZipWith1–ZipWith5implementations callCompleteWithContextwhile holding the queue mutex, and completion synchronously runs teardown, which needs the same mutex. Release the mutex before completing, asZipAllalready does.This follows #381, which fixed premature unsubscription; it addresses the remaining typed-Zip completion deadlock related to #193. The regression waits until subscription setup has returned before draining a completed input, so it deterministically times out on the current main branch. Tests cover all five typed arities and each short-input position, asynchronous futures, context propagation, cancellation, error cleanup, and unsubscribe from the next callback. Operator documentation describes when buffered inputs are exhausted.
Validation: the new regressions and
go test ./...pass locally on Go 1.25; the complete golangci-lint run reports zero issues and the two changed Go files pass the license-header check. Linux CI passes on Go 1.18–1.26 and stable, includingmake testwith the race detector across the workspace. Lint, docs, CodeQL and Bearer also pass. The two Trivy checks fail because.trivyignoreis missing; the main-branch run has the same failure.AI assistance: OpenAI Codex implemented the change, wrote the regression tests, and ran the reported local checks.