V8 windows skill fix#1502
Open
antonioscarinci wants to merge 3 commits into
Open
Conversation
Combines v8's features (uv/pipx detection, graphify-out/ convention, FalkorDB, Step 4.5 health check, directed-graph support, shrink-guard, build_merge --update) with windows-skill-fix's approach (PowerShell throughout, external windows-scripts/*.py, fail-fast, incremental --update fix, Windows encoding fixes). Key changes: - windows-scripts/: all 34 scripts ported to graphify-out/ paths and v8 API (root=, cache_root=, directed=, build_from_json, etc.) - detect_incremental.py: propagates all_files so manifest covers full corpus on --update, not just changed files - check_graph_health.py: new script wrapping v8's diagnostics step - skill-windows.md: rewritten for PowerShell with $GRAPHIFY_SCRIPTS loaded from file each step; --update uses inline build_merge() so edge direction is preserved (safishamsi#801, safishamsi#1344, safishamsi#1361) - export.py: replace None attribute values before nx.write_graphml to avoid AttributeError on None-valued node/edge properties - __main__.py: add --answer-file to graphify save-result to bypass Windows command-line length limit for long answers - .gitattributes: add line-ending normalization rules for .py/.sh (LF) and .bat/.cmd (CRLF) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fix the pyproject.toml so that the Windows skill .py scripts are installed
Three root causes fixed:
1. skill-windows.md: add explicit routing guard so an AI following
'do not skip steps' jumps directly to ## For --update after Step 1
instead of running Steps 2-3 (full detect + full extraction) first.
Also add note after build_merge() block confirming Steps 2-3 must
not be re-run.
2. detect_incremental.py: pass kind='ast' to detect_incremental() as
documented — kind='semantic' (default) mismatches when a prior run
used kind='ast', treating every previously-updated file as changed.
3. save_manifest_and_cost.py: pass detect['files'] (changed files only)
instead of detect.get('all_files') (full corpus). save_manifest()
seeds unchanged entries from the existing manifest, so re-hashing
the entire corpus on every --update is unnecessary and reads every
source file.
The installed bash skill's references/update.md gets the same fix
(incremental['new_files'] instead of incremental['files']).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GLua3wapoQZo5Z4ejhc5qt
safishamsi
pushed a commit
that referenced
this pull request
Jun 29, 2026
…le (#1502) Two cross-platform fixes salvaged from #1502: - to_graphml: nx.write_graphml raises ValueError on None attribute values, so a node/edge carrying a null field crashed the export. Coerce None -> "" for node and edge attributes before writing. - save-result: add --answer-file as an alternative to --answer so long or multiline answers can be passed via a file instead of a fragile inline shell arg (notably Windows/PowerShell quoting). Exactly one of --answer / --answer-file is required. The rest of #1502 (a version downgrade and a hand-edited generated skill-windows.md that fails skillgen --check, plus duplicated windows-scripts) is left for rework on the PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
|
Thanks for this. I pulled the two clean, cross-platform fixes out of here and landed them on
Both shipped with regression tests and verified by smoke (GraphML with Leaving this PR open for the rest, which needs rework before it can merge:
Happy to re-review once those are addressed. Appreciate the Windows focus — it's a real gap. |
safishamsi
added a commit
that referenced
this pull request
Jun 29, 2026
Covers #1499 (Ruby type-aware resolution), #1308/#1541 (workspace exports map), #1529 (alias/workspace import-edge regression), #1531 (tsconfig paths fallbacks), #1527 (semantic cache pruning), #1475 (three ObjC fixes), #1533 (Swift static-call confidence), #1442 (secondary LLM timeout), #1502 (GraphML null coercion + save-result --answer-file), #1530 (host-generic skill wording), and the Dependabot dep bumps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mathieucarbou-ibm
pushed a commit
to mathieucarbou-ibm/graphify
that referenced
this pull request
Jun 29, 2026
…le (safishamsi#1502) Two cross-platform fixes salvaged from safishamsi#1502: - to_graphml: nx.write_graphml raises ValueError on None attribute values, so a node/edge carrying a null field crashed the export. Coerce None -> "" for node and edge attributes before writing. - save-result: add --answer-file as an alternative to --answer so long or multiline answers can be passed via a file instead of a fragile inline shell arg (notably Windows/PowerShell quoting). Exactly one of --answer / --answer-file is required. The rest of safishamsi#1502 (a version downgrade and a hand-edited generated skill-windows.md that fails skillgen --check, plus duplicated windows-scripts) is left for rework on the PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mathieucarbou-ibm
pushed a commit
to mathieucarbou-ibm/graphify
that referenced
this pull request
Jun 29, 2026
Covers safishamsi#1499 (Ruby type-aware resolution), safishamsi#1308/safishamsi#1541 (workspace exports map), safishamsi#1529 (alias/workspace import-edge regression), safishamsi#1531 (tsconfig paths fallbacks), safishamsi#1527 (semantic cache pruning), safishamsi#1475 (three ObjC fixes), safishamsi#1533 (Swift static-call confidence), safishamsi#1442 (secondary LLM timeout), safishamsi#1502 (GraphML null coercion + save-result --answer-file), safishamsi#1530 (host-generic skill wording), and the Dependabot dep bumps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Fixed some issues with the Windows skill and excessive token consumption