Support bulk write on packing containers.#9
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 93.85% 93.91% +0.06%
==========================================
Files 1 1
Lines 488 493 +5
==========================================
+ Hits 458 463 +5
Misses 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@bacek could you please add a unit test that covers the store_.write calls. Currently they are not called. |
Fair call. Added. |
665329c to
60f7a5d
Compare
|
Thanks for adding the unit tests. One last request please rename the test suite to match the other tests. It should be called msgpack23_bulk_write. |
Optimise four hot emit sites (emplace_integral, emplace_combined, pack_type(string), pack_type(vector<B>)) to call store_.write(ptr, len) in one shot instead of iterating byte-by-byte through std::copy. Falls back to std::copy for iterators without write(), so the change is fully backward-compatible. Add a general CTAD deduction guide for any output_iterator that exposes a byte value_type, complementing the existing back_insert_iterator guide. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Done. |
(This sits on top of std::span packing PR#23)