Skip to content

fix(dist): avoid panic for missing undated nightly releases - #5222

Merged
rami3l merged 2 commits into
rust-lang:mainfrom
reidliu41:fix/undated-nightly-missing-release
Nov 17, 2026
Merged

rami3l merged 2 commits into
rust-lang:mainfrom
reidliu41:fix/undated-nightly-missing-release

Conversation

@reidliu41

Copy link
Copy Markdown
Contributor

Rustup enables backtracking when installing or updating an undated nightly
toolchain. If neither the v2 nor v1 channel manifest is available, the download
returns MissingReleaseForToolchain without providing a manifest date.

The missing release is currently treated as skippable, so rustup then attempts
to calculate the previous day from an absent date and panics with exit code 101
instead of reporting a normal command error.

@rami3l rami3l left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

View changes since this review

Comment thread src/dist/mod.rs Resolved
@reidliu41
reidliu41 force-pushed the fix/undated-nightly-missing-release branch from 66d80a2 to 061ba0b Compare November 17, 2026 13:08
Comment thread tests/suite/cli_exact.rs Resolved
@reidliu41
reidliu41 force-pushed the fix/undated-nightly-missing-release branch from 061ba0b to e36db16 Compare November 17, 2026 15:10

@rami3l rami3l left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot :)

View changes since this review

@rami3l
rami3l added this pull request to the merge queue Nov 17, 2026
Merged via the queue into rust-lang:main with commit 134fa1f Nov 17, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants