Repository navigation
fix(completions): account for active toolchain in target completions
#5163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rami3l
merged 8 commits into
rust-lang:main
from
14elias:fix/toolchain-aware-target-completion
Nov 20, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1c96303
test(completions): move similar tests together
rami3l 9fb3494
test(completion): set default toolchain first in some tests
rami3l 50f439c
test(completion): simplify member checks
rami3l ddf0536
test(completion): reorganize imports
rami3l 5c5e3ef
test(completion): rename helper constants
rami3l 8c0ab8d
refactor(config): extract `Cfg::active_toolchain_with_override()`
rami3l 292ae75
test(completions): expose explicit toolchain target selection bugs
14elias 21f8ac2
fix(completions): account for active toolchain in `target` completions
rami3l File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.